[SYCL][DOC] Proposal to add number of HW threads per EU query #4876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It follows https://spec.oneapi.io/level-zero/latest/core/api.html#ze-device-thread-t Also the patch removes several 'supported only on L0 disclaimers' since recently an OpenCL extension was released: https://github.com/KhronosGroup/OpenCL-Docs/blob/master/extensions/cl_intel_device_attribute_query.asciidoc Signed-off-by: Dmitry Sidorov <[email protected]>
MrSidims
force-pushed
the
private/MrSidims/GPURTHWThread
branch
from
4c95f79 to
199e8d5
Compare
MrSidims
added
the
Documentation
MrSidims
commented
Nov 2, 2021
|
|
||
| A new device descriptor will be added which will provide the number of slices on an Intel GPU. If the device is a subdevice, then the number of slices in the subdevice is returned. | ||
|
|
||
| This new device descriptor is only available for devices in the Level Zero platform, and the matching aspect is only true for those devices. The DPC++ default behavior is to expose GPU devices through the Level Zero platform. |
Contributor
Author
There was a problem hiding this comment.
For reference: OpenCL extension for this: https://github.com/KhronosGroup/OpenCL-Docs/blob/master/extensions/cl_intel_device_attribute_query.asciidoc
Contributor
Author
There was a problem hiding this comment.
I'll update the implementation if we agree to remove this disclaimer.
MrSidims
added a commit
to MrSidims/llvm-test-suite
that referenced
this pull request
Nov 4, 2021
Spec update: intel/llvm#4876 Implementation: intel/llvm#4901 Signed-off-by: Dmitry Sidorov <[email protected]>
Contributor
Author
|
@intel/dpcpp-specification-reviewers could you please take a look? IMHO it's quite easy and reasonable proposal. |
gmlueck
approved these changes
Nov 12, 2021
Contributor
gmlueck
left a comment
gmlueck
left a comment
There was a problem hiding this comment.
Yes, this looks good, and it's great to remove some of the Level Zero restrictions.
againull
approved these changes
Nov 12, 2021
MrSidims
added a commit
to MrSidims/llvm
that referenced
this pull request
Nov 23, 2021
The appropriate spec update: intel#4876 Test: intel/llvm-test-suite#550 Signed-off-by: Dmitry Sidorov <[email protected]>
MrSidims
added a commit
to MrSidims/llvm-test-suite
that referenced
this pull request
Dec 8, 2021
Spec update: intel/llvm#4876 Implementation: intel/llvm#4901 Signed-off-by: Dmitry Sidorov <[email protected]>
vladimirlaz
pushed a commit
that referenced
this pull request
Dec 15, 2021
The appropriate spec update: #4876 Test: intel/llvm-test-suite#550 Signed-off-by: Dmitry Sidorov <[email protected]>
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Dec 16, 2021
Spec update: intel/llvm#4876 Implementation: intel/llvm#4901 Signed-off-by: Dmitry Sidorov <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…-test-suite#606) Spec update: intel#4876 Implementation: intel#4901 Signed-off-by: Dmitry Sidorov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It follows https://spec.oneapi.io/level-zero/latest/core/api.html#ze-device-thread-t
Also the patch removes several 'supported only on L0 disclaimers'
since recently an OpenCL extension was released:
https://github.com/KhronosGroup/OpenCL-Docs/blob/master/extensions/cl_intel_device_attribute_query.asciidoc
Signed-off-by: Dmitry Sidorov [email protected]